Variable dictionary format - support Starent #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was careful to only edit logic regarding vendor specific attributes and this change should not affect default packets. Maybe now some public methods can be deleted but I did not want to remove any public methods in order not to break the API. |
|
Could you rebase with "master" so the CI is triggered for this PR? Thanks. |
|
Branch is now rebased with master |
|
Thanks. Does this change warrant a bump in major/minor version? |
ctran
force-pushed
the
master
branch
3 times, most recently
from
67019ad to
5526820
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already see that there was a request to support starent #30 . Unfortunately this vendor changed the spec and introduced 2 byte size of VSA Type and Length fields.
Previous request was not complete and I tried to make a fully scalable solution where we can support different sizes.
This is defined in dictionary and same practices is used by freeradius also.