Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dns-lexicon's Client instead of deprecated providers #27

Merged
merged 5 commits into from
Jun 20, 2024

Conversation

fupduck
Copy link
Contributor

@fupduck fupduck commented Jun 19, 2024

lexicon.providers.* is deprecated and it is suggested to use lexicon.client.Client instead.
Therefore I tried to implement the new approach.

@fupduck fupduck self-assigned this Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.36%. Comparing base (8dc9d21) to head (0cef292).

Files Patch % Lines
certbot_dns_hetzner/dns_hetzner.py 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   89.58%   89.36%   -0.23%     
==========================================
  Files           2        2              
  Lines          48       47       -1     
==========================================
- Hits           43       42       -1     
  Misses          5        5              
Flag Coverage Δ
unittests 89.36% <80.00%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fupduck fupduck marked this pull request as ready for review June 20, 2024 16:10
@fupduck fupduck merged commit d01d568 into main Jun 20, 2024
8 of 9 checks passed
@fupduck fupduck deleted the use_lexicon_client branch June 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant