Skip to content

Commit

Permalink
fix: Update grouping logic for latest active release check
Browse files Browse the repository at this point in the history
  • Loading branch information
adityachoudhari26 committed Nov 11, 2024
1 parent 677a985 commit 7ebf9bb
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions packages/job-dispatch/src/policies/release-sequencing.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,24 +136,24 @@ export const isPassingNewerThanLastActiveReleasePolicy: ReleaseIdPolicyChecker =
.groupBy((rjt) => {
const release = releases.find((r) => r.id === rjt.releaseId);
if (!release) return null;
return [release.deploymentId, rjt.environmentId];
return [rjt.environmentId, rjt.releaseId];
})
.filter(isPresent)
.map((triggers) => _.maxBy(triggers, (t) => t.createdAt)!)
.map((t) => {
const release = releases.find((r) => r.id === t.releaseId);
const release = releases.find((r) => r.id === t[0]!.releaseId);
if (!release) return null;
const deployment = deployments.find(
(d) => d.id === release.deploymentId,
);
if (!deployment) return null;
const activeRelease = deployment.activeReleases.find(
(r) => r.environmentId === t.environmentId,
(r) => r.environmentId === t[0]!.environmentId,
);
if (!activeRelease) return t;
if (release.id === activeRelease.id) return t;
return isAfter(release.createdAt, activeRelease.createdAt) ? t : null;
})
.filter(isPresent)
.value();
.value()
.flat();
};

0 comments on commit 7ebf9bb

Please sign in to comment.