Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: show latest release by deployment and environment #169

Merged
merged 9 commits into from
Oct 26, 2024
Merged
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions packages/api/src/router/deployment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import { JobStatus } from "@ctrlplane/validators/jobs";
import { createTRPCRouter, protectedProcedure } from "../trpc";
import { deploymentVariableRouter } from "./deployment-variable";

const latestReleaseSubQuery = (db: Tx) =>
const latestActiveReleaseSubQuery = (db: Tx) =>
db
.select({
id: release.id,
Expand All @@ -40,12 +40,13 @@ const latestReleaseSubQuery = (db: Tx) =>
name: release.name,
config: release.config,

rank: sql<number>`ROW_NUMBER() OVER (PARTITION BY deployment_id ORDER BY created_at DESC)`.as(
rank: sql<number>`ROW_NUMBER() OVER (PARTITION BY ${release.deploymentId}, ${releaseJobTrigger.environmentId} ORDER BY ${release.createdAt} DESC)`.as(
"rank",
),
})
.from(release)
.as("release");
.innerJoin(releaseJobTrigger, eq(releaseJobTrigger.releaseId, release.id))
.as("active_release");
zacharyblasczyk marked this conversation as resolved.
Show resolved Hide resolved

export const deploymentRouter = createTRPCRouter({
variable: deploymentVariableRouter,
Expand Down Expand Up @@ -203,7 +204,7 @@ export const deploymentRouter = createTRPCRouter({
.on({ type: "system", id: input }),
})
.query(async ({ ctx, input }) => {
const latestRelease = latestReleaseSubQuery(ctx.db);
const latestRelease = latestActiveReleaseSubQuery(ctx.db);
return ctx.db
.select()
.from(deployment)
Expand All @@ -216,7 +217,10 @@ export const deploymentRouter = createTRPCRouter({
)
.where(eq(deployment.systemId, input))
.then((r) =>
r.map((row) => ({ ...row.deployment, latestRelease: row.release })),
r.map((row) => ({
...row.deployment,
latestRelease: row.active_release,
})),
);
}),

Expand Down Expand Up @@ -304,7 +308,7 @@ export const deploymentRouter = createTRPCRouter({
})
.input(z.string().uuid())
.query(async ({ ctx, input }) => {
const latestRelease = latestReleaseSubQuery(ctx.db);
const latestRelease = latestActiveReleaseSubQuery(ctx.db);
return ctx.db
.select()
.from(deployment)
Expand All @@ -318,7 +322,10 @@ export const deploymentRouter = createTRPCRouter({
)
.where(eq(system.workspaceId, input))
.then((r) =>
r.map((row) => ({ ...row.deployment, latestRelease: row.release })),
r.map((row) => ({
...row.deployment,
latestRelease: row.active_release,
zacharyblasczyk marked this conversation as resolved.
Show resolved Hide resolved
})),
);
}),
});
Loading