-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Kubernetes Job Agent #198
Merged
Merged
Changes from 3 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
495b604
fix: Kubernetes Job Agent
zacharyblasczyk 04b7d6f
fix
zacharyblasczyk c6cf741
fix
zacharyblasczyk deeef75
fix
zacharyblasczyk 08fd67d
add external id
zacharyblasczyk ca0fca0
fix
zacharyblasczyk 195aea5
fix
zacharyblasczyk 81cf470
format
zacharyblasczyk 58f2ee5
clean up
jsbroks 3b0b62a
Merge remote-tracking branch 'origin' into fix-kubernetes-job-agent
zacharyblasczyk 00bceb8
schema update from main
zacharyblasczyk cc97ea2
format fix
zacharyblasczyk fa5fbea
use object for manifest
zacharyblasczyk ee1c837
last fix
zacharyblasczyk 890acd3
fix
zacharyblasczyk c5fbf3a
zod validation
zacharyblasczyk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,8 @@ | ||
import { Configuration, DefaultApi } from "@ctrlplane/node-sdk"; | ||
import { createClient } from "@ctrlplane/node-sdk"; | ||
|
||
import { env } from "./config.js"; | ||
|
||
const config = new Configuration({ | ||
basePath: `${env.CTRLPLANE_API_URL}/api`, | ||
export const api = createClient({ | ||
baseUrl: env.CTRLPLANE_API_URL, | ||
apiKey: env.CTRLPLANE_API_KEY, | ||
}); | ||
|
||
export const api = new DefaultApi(config); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enhance null checking for 'job.jobAgentConfig'
The condition
typeof job.jobAgentConfig !== "object"
may not effectively handle cases wherejob.jobAgentConfig
isnull
, sincetypeof null === "object"
. To prevent potential runtime errors, consider adding an explicit null check.Apply this diff to fix the issue:
📝 Committable suggestion