fix: Queue stuff #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbroks
reviewed
Aug 29, 2024
Comment on lines
23
to
28
| type SyncFunction = (je: JobExecution) => Promise<boolean | undefined>; | ||
|
|
||
| const getSyncFunction = (agentType: string): SyncFunction | null => { | ||
| if (agentType === JobAgentType.GithubApp) return syncGithubJobExecution; | ||
| return null; | ||
| }; |
jsbroks
reviewed
Aug 29, 2024
Comment on lines
51
to
56
| function pRetry( | ||
| arg0: () => Promise<number | undefined>, | ||
| arg1: { retries: number; minTimeout: number }, | ||
| ) { | ||
| throw new Error("Function not implemented."); | ||
| } |
There was a problem hiding this comment.
Suggested change
| function pRetry( | |
| arg0: () => Promise<number | undefined>, | |
| arg1: { retries: number; minTimeout: number }, | |
| ) { | |
| throw new Error("Function not implemented."); | |
| } |
import it
jsbroks
reviewed
Aug 29, 2024
Comment on lines
21
to
22
| if (!parsed.success) | ||
| throw new Error(`Invalid job agent config for job execution ${je.id}`); |
There was a problem hiding this comment.
instead of throwing errors set a message and set the status to 'invalid_provider', in the db table
jsbroks
reviewed
Aug 29, 2024
|
|
||
| export const configSchema = z.object({ | ||
| installationId: z.number(), | ||
| login: z.string().min(1), |
There was a problem hiding this comment.
Suggested change
| login: z.string().min(1), | |
| owner: z.string().min(1), |
Should this be in @ctrlplane/validators
jsbroks
reviewed
Aug 29, 2024
| message: (error as Error).message, | ||
| }); | ||
| } | ||
| }), |
There was a problem hiding this comment.
might need a .catch here as well to update status
jsbroks
reviewed
Aug 29, 2024
| owner: config.login, | ||
| repo: config.repo, | ||
| workflow_id: config.workflowId, | ||
| ref: "main", |
There was a problem hiding this comment.
Suggested change
| ref: "main", | |
| ref: config.ref, |
maybe this configurable?
jsbroks
reviewed
Aug 29, 2024
| workflow_id: config.workflowId, | ||
| ref: "main", | ||
| inputs: { | ||
| job_execution_id: je.id.slice(0, 8), |
There was a problem hiding this comment.
slicing to get the external run ID because its only the first 8 of the string
jsbroks
reviewed
Aug 29, 2024
apps/event-worker/src/index.ts
Outdated
Comment on lines
13
to
17
| Promise.all([ | ||
| targetScanWorker.close(), | ||
| dispatchExecutionJobWorker.close(), | ||
| redis.quit(), | ||
| ]); |
There was a problem hiding this comment.
Promise.all makes no difference here if you not await
jsbroks
reviewed
Aug 29, 2024
packages/job-dispatch/src/config.ts
Outdated
Comment on lines
7
to
8
| AMQP_URL: z.string().optional(), | ||
| AMQP_QUEUE: z.string().default("job_configs"), |
There was a problem hiding this comment.
Suggested change
| AMQP_URL: z.string().optional(), | |
| AMQP_QUEUE: z.string().default("job_configs"), |
jsbroks
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queue supremacy