-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for query parameters #19
Conversation
Sorry, I dropped the ball on this. I like the PR, and an API change is just fine. We can make a new version and that's it. I am worried of breaking something:
😬 What do you think is broken? |
In my current (work-)project I don't need the Link-Component (because I implement only webcomponents in yew, integrated into a bigger angular application, so the router is implemented in angular). |
let router = match use_router::<T>() { | ||
None => { | ||
error!("No router"); | ||
return html! {"Need Router or Nested component"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of like the idea of not-panicking.
What's the state of the PR. I am ok merging, even with breaking changes. As long as the other stuff still works. |
It is a mixed bag. Partially it is already rolled out in a productive project, but I have newer used in a standalone yew application, so there could be some horrible undetected bugs. |
That's fair. I'll make it a breaking release then, so that people need to opt-in. |
I think there are two warnings in the generated code:
|
Yes. I couldn't fined out, why these parameters where needed, so when someone finds it out, he can easier fix the problem. |
The PR is not ready now. I will send it again, when it is more ready. |
I found no solution without an API change.
The Implementation is still rough, but the unit tests run through.
Could be a solution for #9
Possible I killed a feature by ignoring converter and target_converter at https://github.com/koa/yew-nested-router/blob/719392b53860046425eca288a4416af8f7aa8b54/yew-nested-router-macros/src/lib.rs#L337, so i leaved the parameters for the moment.