move js class initialization to constructor

cubicap · Dec 7, 2023 · d30ecba · d30ecba
1 parent 6a99ed7
commit d30ecba
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/main/espFeatures/analogFeature.h b/main/espFeatures/analogFeature.h
@@ -91,12 +91,15 @@ class AnalogFeature : public Next {
 public:
     using AnalogClass = jac::Class<AnalogProtoBuilder<AnalogFeature>>;
 
+    AnalogFeature() {
+        AnalogClass::init("Analog");
+    }
+
     void initialize() {
         Next::initialize();
 
         auto& module = this->newModule("embedded:io/analog");
 
-        AnalogClass::init("Analog");
         AnalogClass::initContext(this->context());
 
         module.addExport("Analog", AnalogClass::getConstructor(this->context()));

diff --git a/main/espFeatures/digitalFeature.h b/main/espFeatures/digitalFeature.h
@@ -325,6 +325,10 @@ class DigitalFeature : public Next {
 public:
     using DigitalClass = jac::Class<DigitalProtoBuilder<DigitalFeature>>;
 
+    DigitalFeature() {
+        DigitalClass::init("Digital");
+    }
+
     void initialize() {
         Next::initialize();
 
@@ -339,7 +343,6 @@ class DigitalFeature : public Next {
 
         auto& module = this->newModule("embedded:io/digital");
 
-        DigitalClass::init("Digital");
         DigitalClass::initContext(this->context());
 
         jac::Object digitalConstructor = DigitalClass::getConstructor(this->context());
@@ -358,8 +361,6 @@ class DigitalFeature : public Next {
         digitalConstructor.set("Falling", DigitalEdge::FALLING);
     }
 
-    DigitalFeature() {}
-
     ~DigitalFeature() {
         for (auto pin : PinConfig::INTERRUPT_PINS) {
             gpio_intr_disable(Next::getDigitalPin(pin));