Fixes #7
Merged
Fixes #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasssadar
commented
Jul 8, 2024
Comment on lines
+270
to
+275
| ~MotorFeature() { | ||
| for(auto& motor : _motors) { | ||
| auto& jsdcMotor = *MotorProtoBuilder<MotorFeature<Next>>::getOpaque(this->context(), motor); | ||
| jsdcMotor.clear(); | ||
| } | ||
| } |
There was a problem hiding this comment.
If the pendingPromise is not freed BEFORE JS_FreeRuntime, quickjs goes into assert thinking there is a memory leak. It would actually free the promises later, but during the leak check, references from imported modules are still alive, so the leak check happens before the export const reference on motor is freed and before JSDCMotor finalizer is called.
So it's the leak check being wrong, but it means it crashes program during uploading if you use motors but don't resolve the promise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.