Fix some problems that arise when modeling megaminx. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(when orientation counts might exceed 2^31 options). Also, the unpackVector was assuming all values are >0, but that's not the case for orientations, so added an offset of 1 on pack and subtracted that offset on unpack.
This was apparently broken when someone "wrapped" ksolve.
create executables called ksolve. No need to use wine as this program compiles trivially on Unix.
This needs to be configurable at runtime.
often more compact, but most importantly works correctly for puzzles that have permutations with more than 20 elements.
gives another small speed bump.
ints. If this works the next step is to change them from maps to vectors where possible.
broke some functionality.
small things on small machines.
Also, substantially sped up index calculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed four separate issues that arise when trying to model the megaminx.
Corners now work. Edges will need further fixes (support for permutations
with more than 20 pieces).