Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version support of all cucumber gems #1751

Merged
merged 11 commits into from
Feb 13, 2024
Merged

Update version support of all cucumber gems #1751

merged 11 commits into from
Feb 13, 2024

Conversation

luke-hill
Copy link
Contributor

Description

Begin to use latest versions of all refactored / tidied up gems

Type of change

Please delete options that are not relevant.

  • Refactoring (improvements to code design or tooling that don't change behaviour)
  • New feature (non-breaking change which adds new behaviour)

Some new stuff from the core gem the rest is just tech debt fixes

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • Tests have been added for any changes to behaviour of the code
  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

@luke-hill
Copy link
Contributor Author

Note to self.

CI run 1: 59 failures
CI run 2: 14 failures
TODO: Release patch fix of core (Should get failures down to single digits). This will need enforcing for gemspec

@luke-hill luke-hill merged commit a4598d9 into main Feb 13, 2024
15 checks passed
@luke-hill luke-hill deleted the cucumber_gem_bump branch February 13, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant