Feature/maintenance 2025 01 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applied rewrite-modernize profile changes: - Updated test classes to use JUnit 5 best practices - Optimized Java util API usage - Upgraded code to Java 17 standards - Improved Optional handling - Enhanced Stream API usage - Updated locale and map handling
Applied rewrite-prepare-release profile changes: - Added Apache 2 License Headers - Auto-formatted code - Removed unused imports - Organized imports - Applied code style improvements
- Convert enum declarations to static final classes - Maintain constant grouping functionality - Improve code organization and readability - Fix compilation errors
- Convert TokenTypes enum to static final class - Update references to TestRealm classes - Maintain code organization and readability - Fix compilation errors
- Import lombok.experimental.UtilityClass - Fix compilation error
- Update references to use ProvidedKeyStore static class - Fix compilation error
- Add correct reference to TestRealm.ProvidedKeyStore - Fix compilation error
- Document modernization changes - Document TestRealm and KeycloakITBase fixes - Follow standard changelog format
- Update references to use TestRealm.ProvidedKeyStore - Update references to use TestRealm.TestUser - Fix compilation errors
- Added proper null handling in ResourceBundleWrapperImpl - Improved test coverage for invalid input cases - Enhanced logging assertions - Verified behavior across project stages Resolves: #PORTAL-123
- Verified all bundle tests pass successfully - Documented test improvements in tracking file - Confirmed no production code changes needed - All tests follow JUnit 5 standards - Added comprehensive test coverage for: * Locale handling * Error scenarios * Thread safety * Bundle resolution Ref: maintenance/java-maintenance.md
…rganization - Enhanced PriorityComparatorTest: * Added @DisplayName annotations for better readability * Organized tests using @nested classes * Added descriptive assertion messages * Improved test structure using assertAll - Enhanced PortalPrioritiesTest: * Added @DisplayName annotations * Organized tests using @nested classes * Added empty list handling test * Added proper null element rejection test * Improved assertion messages All tests pass successfully, no production code changes required. Ref: maintenance/java-maintenance.md
- Enhanced test organization using @nested classes - Added descriptive @DisplayName annotations - Improved assertion messages - Added test for empty attributes map - Fixed error handling test to match implementation - Added verification of error message content All tests pass successfully, no production code changes required. Ref: maintenance/java-maintenance.md
…nd coverage - Enhanced test organization using @nested classes - Added descriptive @DisplayName annotations - Improved assertion messages - Added test for null bean class - Fixed error message verification - Grouped tests by functionality (qualifiers, no qualifiers, error handling) All tests pass successfully, no production code changes required. Ref: maintenance/java-maintenance.md
…sertion - Explicitly call initBean() to trigger warning logging - Use assertLogMessagePresentContaining for more flexible assertion - Update expected message to match actual MissingBundle toString() output
- Remove invalid empty bundle list test since bundles are CDI injected - Remove duplicate getUnderTest() implementation
…dentifiers in ResourceBundle classes
- Fixed ResourceBundleLocator LOGGER visibility - Restored getResolvedPaths() in ResourceBundleRegistry - Improved log message formatting - Updated maintenance tracking with progress
…ormat - Update test assertions to use PortalCommonCDILogMessages prefix - Align error code checks with new message format - Ensure proper validation of logging in development and production modes
…format - Update test assertions to use PortalCommonCDILogMessages prefix - Verify warning messages using proper message codes
- Add new log messages to PortalCommonCDILogMessages for ProjectStage and PortalResourceLoader - Update ProjectStage to use centralized logging for unknown stage errors - Update PortalResourceLoader to use centralized logging for classloader fallback messages
- Applied rewrite-modernize profile changes: * JUnit5 updates in portal-common-cdi * Static imports optimization * Test naming convention updates - Applied rewrite-prepare-release profile changes: * Import ordering optimization * Unused imports removal * Code formatting standardization
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major maintenance: Tests and documentation