Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Dynamically Registered Clients #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

anestos
Copy link

@anestos anestos commented Jan 14, 2025

No description provided.

@anestos anestos requested review from suren-khatana, daniellindau and pjoshi2023 and removed request for suren-khatana January 15, 2025 13:36
Copy link
Member

@daniellindau daniellindau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

public void update(DynamicallyRegisteredClientAttributes attributes) {
String clientId = attributes.getClientId();
_logger.debug("Updating dynamic client with ID: {} and attributes : {}", clientId, attributes);
sendHttpRequest(HttpMethod.PUT.getMethodString(), String.join("/", _configuration.urlPath(), clientId), _json.toJson(attributes));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is an update always the full client? Not a PATCH?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants