Merge pull request #467 from curveball/fix-knex-warning

Fix knex warning for sqlite3 not supporting default values
curveball · Sep 24, 2023 · 2a39b85 · 2a39b85
2 parents 8f812a9 + eec88b4
commit 2a39b85
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/changelog.md b/changelog.md
@@ -9,6 +9,7 @@ Changelog
   should be no end-user effects to this.
 * Added a system group principal , which allows admins to set privileges for
   every user in the system.
+* Fix Sqlite startup warning.
 
 
 0.23.1 (2023-03-29)

diff --git a/src/database.ts b/src/database.ts
@@ -74,6 +74,7 @@ export function getSettings(): Knex.Config {
   let connection: Knex.MySql2ConnectionConfig | Knex.PgConnectionConfig | Knex.Sqlite3ConnectionConfig;
   let client;
   let searchPath;
+  let useNullAsDefault: undefined|true = undefined;
 
   if (process.env.PG_DATABASE) {
 
@@ -159,8 +160,9 @@ export function getSettings(): Knex.Config {
         }
 
         connection = {
-          filename: process.env.DB_FILENAME || 'a12nserver.sqlite3'
+          filename: process.env.DB_FILENAME || 'a12nserver.sqlite3',
         };
+        useNullAsDefault = true;
         break;
 
       default:
@@ -181,6 +183,7 @@ export function getSettings(): Knex.Config {
     },
     pool: { min: 0, max: 10 },
     debug: process.env.DEBUG ? true : false,
+    useNullAsDefault: useNullAsDefault,
   };
 
   return settings;