Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new enforce_value_in_range config option, disable by default #16

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Create new enforce_value_in_range config option, disable by default #16

merged 1 commit into from
Jul 30, 2019

Conversation

TheLastProject
Copy link
Contributor

I've started using bar-card to display the temperature of my house and the desired minimum and maximum temperature. This does, however, mean that the temperature can be outside this range until the house has heated/cooled enough. Because bar-card automatically forces the value to be within the minimum and maximum, this breaks my use case. This small patch fixes it.

I've also disabled this old behaviour by default, because I assume people will generally want to see the real value unless they explicitly mention to want it post-processed to always be within min and max. If you disagree, I'll change the default back to match the old behaviour by default.

Before (true value hidden):
image

After (true value shown):
image

@Gluwc Gluwc merged commit 587bf22 into custom-cards:master Jul 30, 2019
@Gluwc
Copy link
Member

Gluwc commented Jul 30, 2019

I've renamed this config option to limit_value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants