Map address validation exceptions to VertexClient::ValidationError #58
+57
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is needed to handle validation differently in the client.
|
Missing a bump in |
|
Hmm, looks like I also need to remove safe navigation due to 2.1 support. |
|
you could technically wait till I push out the v1.0.0 which increases the minimum ruby version needed. But I assume you need this for a low-ruby project? |
|
Awesome. I can wait for 1.0.0. This update is for groups which Dan has updated to 2.5.3 |
|
This PR is open and inactive for 30 days. Merging PRs open after a long time is error-prone. Please proceed to merging or make a comment to keep it open. You can also prevent PRs from being tagged stale or closed with 'keep-open' tag. If there is no activity in 90 days, this PR will be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to convert common address validation errors masquerading as
Savon::SOAPFaultsintoVertexClient::ValidationErrors. This should allow the client to handle these exceptions and continue processing.As an example, the Groups app would be able to use some default value for address validation errors, but because SOAPFaults could be a more serious networking issue processing ends and the user receives a 500 page.
Changes
The error codes present in the address validation exceptions are found here. By parsing out the error code a
VertexClient::ValidationErrorcan be raised instead of a SOAPFault for the subset of the error codes pertaining to address validation. TheVertexClient::ValidationErrorexception is already in use for other validation in this client.JIRA Ticket
XX-1234
Screenshots
Notes