Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1685: Harmony parsing errors with doubled characters #1688

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Fix #1685: Harmony parsing errors with doubled characters #1688

merged 2 commits into from
Mar 3, 2024

Commits on Feb 24, 2024

  1. Fix harmony parsing errors with doubled characters 

    The code intended to only remove the parsed `chordKind` from the string, but in cases where the `chordKind` char occurs multiple times, this would remove all occurrences of the char.
    @TimFelixBeyer
    TimFelixBeyer authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    944b985 View commit details
    Browse the repository at this point in the history

  2. Add regression test

    @TimFelixBeyer
    TimFelixBeyer authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    e11427c View commit details
    Browse the repository at this point in the history