Skip to content

Commit

Permalink
chore: fix some typos in comment (#8868)
Browse files Browse the repository at this point in the history
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->

 fix some typos in comment
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [ ] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [ ] I have updated the documentation accordingly
- [ ] I have added tests to cover my changes
- [ ] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [ ] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [ ] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Corrected typographical errors in comments and messages across various
components, enhancing clarity.
- Updated comments related to ingress configuration in the Helm chart
for better understanding.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: cuiweiyuan <[email protected]>
  • Loading branch information
cuiweiyuan authored Dec 25, 2024
1 parent 6e3b5f8 commit 85223f5
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion cvat-core/src/annotations-actions/base-action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ export function validateClientIDs(collection: Partial<SerializedCollection>) {
collection.tracks ?? [],
collection.tags ?? [],
).forEach((object) => {
// clientID is required to correct collection filtering and commiting in annotations actions logic
// clientID is required to correct collection filtering and committing in annotations actions logic
if (typeof object.clientID !== 'number') {
throw new Error('ClientID is undefined when running annotations action, but required');
}
Expand Down
2 changes: 1 addition & 1 deletion cvat-core/src/annotations-actions/base-shapes-action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export async function run(
}
}

await showMessageWithPause('Commiting handled objects', 100, 1500);
await showMessageWithPause('Committing handled objects', 100, 1500);
if (cancelled()) {
return;
}
Expand Down
2 changes: 1 addition & 1 deletion cvat-ui/src/utils/is-able-to-change-frame.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function isAbleToChangeFrame(frame?: number): boolean {
if (typeof frame === 'number') {
if (meta.includedFrames) {
// frame argument comes in job coordinates
// hovewer includedFrames contains absolute data values
// however includedFrames contains absolute data values
frameInTheJob = meta.includedFrames.includes(meta.getDataFrameNumber(frame - job.startFrame));
}

Expand Down
2 changes: 1 addition & 1 deletion helm-chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ ingress:
## kubernetes.io/ingress.class: nginx
##
annotations: {}
## @param ingress.className IngressClass that will be be used to implement the Ingress (Kubernetes 1.18+)
## @param ingress.className IngressClass that will be used to implement the Ingress (Kubernetes 1.18+)
## This is supported in Kubernetes 1.18+ and required if you have more than one IngressClass marked as the default for your cluster
## ref: https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/
##
Expand Down

0 comments on commit 85223f5

Please sign in to comment.