-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test_export_with_non_default_frame_step compatible with Python 3.11+ #8927
Conversation
….11+ In Python 3.11, `Enum.__format__` was changed to be the same as `Enum.__str__`, so the yielded format name ends up being `CVAT for _SourceDataType.images 1.1`. Use the string value explicitly. Also, remove the `str` base class from `_SourceDataType`, since it appears to be actively misleading (as well as unnecessary).
WalkthroughThe pull request involves modifying the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, I will update to Python3.11 on my azure machine to be able to check such errors in the future
Motivation and context
In Python 3.11,
Enum.__format__
was changed to be the same asEnum.__str__
, so the yielded format name ends up beingCVAT for _SourceDataType.images 1.1
. Use the string value explicitly.Also, remove the
str
base class from_SourceDataType
, since it appears to be actively misleading (as well as unnecessary).How has this been tested?
I ran the test with Python 3.12.
Checklist
develop
branch[ ] I have created a changelog fragment[ ] I have updated the documentation accordingly[ ] I have added tests to cover my changes[ ] I have linked related issues (see GitHub docs)(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
_SourceDataType
class to use standard Enum implementation