backup task created from cloud #8972
Conversation
| assert not hasattr(self._db_data, 'video'), "Only images can be stored in cloud storage" | ||
| media_files = [im.path for im in self._db_data.images.all()] | ||
| cloud_storage_instance = db_storage_to_storage_instance(self._db_data.cloud_storage) | ||
| with tempfile.TemporaryDirectory() as tmp_dir: |
There was a problem hiding this comment.
Images can be:
- 2d and 3d
- raw and archive
There can also be related images. Probably, they are not included.
Please check these cases.
There was a problem hiding this comment.
added tests for video, archives and pdfs with images. Though, as far as I understand, they are downloaded from cloud on task creation and cloud is not needed for them anymore.
Also added tests with and without static chunks.
As far as I understand, right now it is not possible to create a task with 3d images from cloud, and to create a task with related images from cloud. Should I make it possible in this PR?
There was a problem hiding this comment.
they are downloaded from cloud on task creation and cloud is not needed for them anymore.
Yes, only bare images can be used remotely so far, everything else is downloaded.
As far as I understand, right now it is not possible to create a task with 3d images from cloud, and to create a task with related images from cloud. Should I make it possible in this PR?
Please keep this PR focused.
|
Please update the changelog |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8972 +/- ##
===========================================
+ Coverage 73.42% 73.89% +0.47%
===========================================
Files 419 428 +9
Lines 44351 44516 +165
Branches 3875 3875
===========================================
+ Hits 32563 32897 +334
+ Misses 11788 11619 -169
|
|
Motivation and context
Making a backup for tasks/projects created from cloud storage
How has this been tested?
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.