Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D Arrangement Documentation and Test Improvement [CAT] #70

Open
wants to merge 38 commits into
base: julia-1.0
Choose a base branch
from

Conversation

eOnofri04
Copy link
Collaborator

@eOnofri04 eOnofri04 commented Apr 23, 2019

Easter Assignment 2019 from @apaoluzzi .

Do note the following changes:

  • r86, src/arrangement/planar_arrangement.jl
            if i != edge_idx && edge_idx in bigPI[i]    #<------------------------- Could be usefull?
            intersection = Lar.Arrangement.intersect_edges(V, edge, EV[i, :])
    
  • r196, src/arrangement/planar_arrangement.jl function merge_vertices! has been redefined.
  • r736, src/arrangement/planar_arrangement.jl The ouptut V of the function seems to be not modified. Therefore could it be safely eliminated?
  • r864, src/arrangement/planar_arrangement.jl function cleandecomposition seems to be not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant