Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support larger python version #108

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

gatheluck
Copy link
Contributor

@gatheluck gatheluck commented Jul 23, 2024

Issue URL

#107

Change overview

  • Update Dockerfile to support python 3.10, 3.11, 3.12.
  • Add python 3.10, 3.11, 3.12 to CI build matrix.
  • Update python badge in README.md.
  • Make default Python version to 3.12.

How to test

Please test following from Python 3.8 to 3.12 since build with GPU is not supported by CI now.

% cd environments/gpu
% sudo docker compose build --build-arg PYTHON_VERSION=<PLEASE_SPECIFY_PYTHON_VERSION>
% sudo docker compose exec core bash

# enter the container and check python version
$ python --version

On the other hand, build with CPU is tested by CI jobs.

Note for reviewers

NA

@gatheluck gatheluck self-assigned this Jul 23, 2024
@gatheluck gatheluck added the enhancement New feature or request label Jul 23, 2024
Copy link
Collaborator

@YoshikiKubotani YoshikiKubotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check one minor suggestion

environments/Dockerfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@YoshikiKubotani YoshikiKubotani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatheluck gatheluck merged commit 8f59e3e into develop Jul 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants