Merge pull request #8 from MartialGeek/free_space

Fix #7 : Add missing return statement in the freeSpace method
cyb3rd4d · Mar 8, 2016 · 860496e · 860496e
2 parents b5509c2 + 063f49c
commit 860496e
Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/RpcClient.php b/src/RpcClient.php
@@ -477,7 +477,9 @@ public function queueMoveBottom($sessionId, array $ids)
      */
     public function freeSpace($sessionId, $path)
     {
-        $this->sendRequest($sessionId, $this->buildRequestBody('free-space', ['path' => $path]));
+        $response = $this->sendRequest($sessionId, $this->buildRequestBody('free-space', ['path' => $path]));
+
+        return $response['arguments'];
     }
 
     /**

diff --git a/tests/RpcClientTest.php b/tests/RpcClientTest.php
@@ -1713,14 +1713,24 @@ public function testQueueMoveBottomShouldThrowAnExceptionWithAnInvalidSessionId(
     public function testFreeSpaceWithSuccess()
     {
         $requestBody = '{"method":"free-space","arguments":{"path":"/var/lib/transmission-daemon/downloads"}}';
+        $path = '/var/lib/transmission-daemon/downloads';
+        $size = 37548523520;
 
         $this
             ->sendRequest($requestBody)
             ->andReturn($this->guzzleResponse);
 
-        $jsonResponse = '{"arguments":{"path":"/var/lib/transmission-daemon/downloads","size-bytes":37548523520},"result":"success"}';
+        $jsonResponse = sprintf(
+            '{"arguments":{"path":"%s","size-bytes":%d},"result":"success"}',
+            $path,
+            $size
+        );
+
         $this->setResponseBody($jsonResponse);
-        $this->rpcClient->freeSpace($this->sessionId, '/var/lib/transmission-daemon/downloads');
+        $result = $this->rpcClient->freeSpace($this->sessionId, $path);
+        $this->assertInternalType('array', $result);
+        $this->assertSame($path, $result['path']);
+        $this->assertSame($size, $result['size-bytes']);
     }
 
     public function testFreeSpaceShouldThrowAnExceptionWhenThePathIsInvalid()