Skip to content

Commit

Permalink
CI: add missing docker-pull
Browse files Browse the repository at this point in the history
  • Loading branch information
JonJagger committed Dec 28, 2023
1 parent 9cd4401 commit fe36930
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/snyk_scan_aws_prod.yml.off
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ jobs:
uses: snyk/actions/setup@master

- name: Run Snyk
run:
run: |
KOSLI_ENVIRONMENT=aws-prod
./snyk_scan_live_artifacts_and_report_to_kosli.sh "${KOSLI_ENVIRONMENT}"
11 changes: 11 additions & 0 deletions docs/errors.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@

https://github.com/cyber-dojo/snyk_scans/actions/runs/7347288136/job/20003459005
Error: Error: No such image: ***.dkr.ecr.eu-central-1.amazonaws.com/runner:d3fe336
- Dont repeat Error:
- What is the actual error?
In this case I think it is because the snyk-scan ran on
***.dkr.ecr.eu-central-1.amazonaws.com/runner:d3fe336@sha:${fingerprint}
but the name of the image, in the kosli commands is
***.dkr.ecr.eu-central-1.amazonaws.com/runner:d3fe336
without the trailing
@sha:${fingerprint}
2 changes: 2 additions & 0 deletions snyk_scan_live_artifacts_and_report_to_kosli.sh
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ report_snyk_vulnerabilities_to_kosli()
--description="Scan of deployed Artifacts running in their Environment" \
--template=artifact,snyk-scan

docker pull "${image_name}"

kosli report artifact "${image_name}" \
--artifact-type=docker

Expand Down

0 comments on commit fe36930

Please sign in to comment.