Fix aws connector automatic endpoint discovery #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were 2 bugs.
1. We modified only req.URL{Scheme, Host} with the new endpoint, we missed req.Host.
2. We were modifying the endpoint after signing the request.
2 did not show up until 1 was resolved. This is likely because the request signing doesn't
take req.URL{Scheme, Host} into account.
diverdane
previously approved these changes
Jan 27, 2021
|
@diverdane Thanks, CHANGELOG entry added |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
doodlesbykumbi
force-pushed
the
fix-aws-endpoint
branch
from
f46e95e to
b54d2d9
Compare
|
Code Climate has analyzed commit b54d2d9 and detected 1 issue on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 53.0% (0.0% change). View more on Code Climate. |
|
@doodlesbykumbi this may be out of scope for this PR, but I think I saw you mention a mock AWS server that we might be able to use for AWS integration tests. should we file an issue in this project to implement that? it would have been nice to have some integration tests for this connector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What's changed? Why were these changes made?
There were 2 bugs.
2 did not show up until 1 was resolved. This is likely because the request signing doesn't
take req.URL{Scheme, Host} into account.
How should the reviewer approach this PR, especially if manual tests are required?
N/A
Are there relevant screenshots you can add to the PR description?
N/A.
What ticket does this PR close?
Resolves #1369
Checklists
Change log
Test coverage
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs(For releases only) Manual tests