-
Notifications
You must be signed in to change notification settings - Fork 9
Added GDPR field #239
base: master
Are you sure you want to change the base?
Added GDPR field #239
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Also needs a rebase if we will go forward with this.
@@ -12,7 +12,8 @@ | |||
"seller": 1, | |||
"semester": 6, | |||
"uio_username": null, | |||
"user": null | |||
"user": null, | |||
"gdpr_approval": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix indentation, see also other lines
@@ -14,7 +14,7 @@ class Migration(migrations.Migration): | |||
operations = [ | |||
migrations.AddField( | |||
model_name='member', | |||
name='last_edited_by', | |||
name='gdpr_approval', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shouldn't be changed
@@ -32,6 +33,7 @@ class Member(models.Model): | |||
uio_username = models.CharField(max_length=15, null=True, blank=True) | |||
comments = models.TextField(null=True, blank=True) | |||
last_edited_by = models.ForeignKey(User, related_name='modifier', null=True) | |||
gdpr_approval = models.BooleanField(default=False, help_text='Privacy policy agreement') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Antakeligvis bedre om vi hadde brukt en dato her, slik at man kan forstå når det skjedde.
Har vi egentlig noen policy liggende noe sted?
Viser forøvrig til diskusjon på Slack: https://cybernetisk.slack.com/archives/C03QDK7CV/p1547123717047400
Det ble aldri konkludert med hva som var det reelle behovet, og om det faktisk er nødvendig med samtykke. Og det fremkommer f.eks. ikke hva man i så fall samtykker til, og hvordan evt. samtykke kan trekkes tilbake og hva slags betydning det får.
Added fields for GDPR in member model. Please have a look 😄