Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to be able to remove AddressPool finalizer by controller #283

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix to be able to remove AddressPool finalizer by controller #283

merged 1 commit into from
Apr 23, 2024

Conversation

terassyi
Copy link
Contributor

@terassyi terassyi commented Apr 22, 2024 •
edited by ymmt2005
Loading

Fix #268

@terassyi terassyi self-assigned this Apr 22, 2024
@terassyi terassyi linked an issue Apr 22, 2024 that may be closed by this pull request
Unable to delete AddressPool #268
Closed
ymmt2005
ymmt2005 approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@ymmt2005 ymmt2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@terassyi terassyi marked this pull request as ready for review April 23, 2024 00:06
@terassyi terassyi merged commit 7db1096 into main Apr 23, 2024
7 checks passed
@terassyi terassyi deleted the fix-to-be-able-to-remove-ap-finalizer branch April 23, 2024 00:06
@terassyi terassyi mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymmt2005 ymmt2005 ymmt2005 approved these changes

Assignees

@terassyi terassyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to delete AddressPool
2 participants
@terassyi @ymmt2005