Add Updated Conditon in Status #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@YZ775 |
zoetrope
reviewed
Jul 26, 2023
YZ775
commented
Jul 26, 2023
zoetrope
reviewed
Jul 26, 2023
zoetrope
reviewed
Jul 26, 2023
YZ775
force-pushed
the
add-statefulset-condition
branch
3 times, most recently
from
a21f064
to
60e7997
Compare
masa213f
reviewed
Jul 27, 2023
|
Please add documentation for this feature to reconcile.md. |
masa213f
requested changes
Jul 27, 2023
YZ775
force-pushed
the
add-statefulset-condition
branch
from
1e924b7
to
cb5e6f7
Compare
masa213f
requested changes
Aug 8, 2023
masa213f
requested changes
Aug 18, 2023
masa213f
requested changes
Aug 21, 2023
| log := crlog.FromContext(ctx) | ||
| orig := cluster.DeepCopy() | ||
|
|
||
| if cluster.Status.ReconcileInfo.Generation != cluster.Generation { |
There was a problem hiding this comment.
This if statement is unnecessary.
Currently, we use DeepEqual() to determine whether or not an update is required.
…Condition Signed-off-by: YZ775 <[email protected]> add envtest Signed-off-by: YZ775 <[email protected]> update gomod Signed-off-by: YZ775 <[email protected]> update envtest and add e2e Signed-off-by: YZ775 <[email protected]> update apidoc Signed-off-by: YZ775 <[email protected]> rename Signed-off-by: YZ775 <[email protected]> add ObservedGeneration and add partition handling, and update e2e test Signed-off-by: YZ775 <[email protected]> remove unnecessary ObservedGeneration and move updateStatus() after reconcileV1StatefulSet() , and update e2e test Signed-off-by: YZ775 <[email protected]> add document about UpToDate Signed-off-by: YZ775 <[email protected]> update against review Signed-off-by: YZ775 <[email protected]> wip change status to StatefulSetReady and add ReconcileSuccess, and fix unstable test Signed-off-by: YZ775 <[email protected]> remove unnecessary condition check Signed-off-by: YZ775 <[email protected]> remove redundant assignments in updateStatusByStatefulSet Signed-off-by: YZ775 <[email protected]> move updateReconcileStatus in reconcileV1 Signed-off-by: YZ775 <[email protected]> fix controller test Signed-off-by: YZ775 <[email protected]> update documents Signed-off-by: YZ775 <[email protected]> update lifecycle_test.go to check StatefulSetReady condition Signed-off-by: YZ775 <[email protected]> fix auto generated document Signed-off-by: YZ775 <[email protected]> join update status funcion Signed-off-by: YZ775 <[email protected]> revert Eventually in envtest Signed-off-by: YZ775 <[email protected]> fix multiple Update() call Signed-off-by: YZ775 <[email protected]> update docs Signed-off-by: YZ775 <[email protected]> fix controller Signed-off-by: YZ775 <[email protected]> update condition when sts not found Signed-off-by: YZ775 <[email protected]> update test Signed-off-by: YZ775 <[email protected]> update lifecycle_test.go Signed-off-by: YZ775 <[email protected]> fix condition Signed-off-by: YZ775 <[email protected]> fix generation check and err handling Signed-off-by: YZ775 <[email protected]> do not show err log when deletion of cluster Signed-off-by: YZ775 <[email protected]> add StatefulSet condition and change MySQLClusterCondition to metav1.Condition Signed-off-by: YZ775 <[email protected]>
YZ775
force-pushed
the
add-statefulset-condition
branch
from
482edb0
to
b7d6985
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The health status in
MySQLCluster.Status.Conditionwill be true even if all StatefulSet is not ready when updating MySQLCluster.So if we use this status as a health check in ArgoCD, they proceed next wave in spite of the update of MySQLCluster is not finished.
As a solution to this problem, I added
ConditionUpdatedCondition inMySQLCluster.Status.Condition.This condition will become true when an update of Statefulset is finished.
This PR contains following improvement
metav1.Conditioninstead ofMySQLClusterCondition