Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add designdoc for Safe Rolling Update of StatefulSet #628

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Conversation

d-kuro
Copy link
Contributor

@d-kuro d-kuro commented Dec 20, 2023

refs: #622

@d-kuro d-kuro changed the title add designdoc for Safe Rolling Update of StatefulSet Add designdoc for Safe Rolling Update of StatefulSet Dec 20, 2023
@d-kuro d-kuro self-assigned this Dec 20, 2023
@d-kuro d-kuro requested a review from zoetrope December 20, 2023 05:26
@d-kuro d-kuro marked this pull request as ready for review December 20, 2023 05:26
@zoetrope zoetrope requested review from kmdkuk and yamatcha and removed request for zoetrope January 25, 2024 02:11
kmdkuk
kmdkuk previously approved these changes Feb 19, 2024
Copy link
Contributor

@kmdkuk kmdkuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yamatcha
yamatcha previously approved these changes Feb 20, 2024
@d-kuro d-kuro dismissed stale reviews from yamatcha and kmdkuk via 0a52cbe March 13, 2024 04:56
Comment on lines 38 to 41
### When creating MySQLCluster

Until MySQLCluster successfully starts for the first time, applies StatefulSet without setting `.partition`.
This is done to prevent a situation where a user-corrected StatefulSet, due to misconfigurations like image issues, does not roll out due to partition.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this description. Now we set the partition when creating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I fixed: 111de97

Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@masa213f masa213f merged commit 98db868 into main Aug 30, 2024
17 checks passed
@masa213f masa213f deleted the d-kuro/update branch August 30, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants