Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MySQL 8.0.36 container image #667

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Add MySQL 8.0.36 container image #667

merged 1 commit into from
Apr 26, 2024

Conversation

takara9
Copy link
Contributor

@takara9 takara9 commented Apr 23, 2024 •
edited
Loading

This update procedure is in https://neco.cybozu.wiki/procedure_moco_maintenance/#mysql
Add new MySQL ver 8.0.36

@takara9 takara9 self-assigned this Apr 23, 2024
@morimoto-cybozu
Copy link
Contributor

@takara9
Can I really review this pull request?
It seems that the preceding pull requests are still in progress.
#665
#666

@takara9
Copy link
Contributor Author

takara9 commented Apr 23, 2024

@morimoto-cybozu
In my understand, Yes, you can.
#665,#666,#667 can be paralell task.
For each task needs marge indepently before Moco updating task.

@takara9
Copy link
Contributor Author

takara9 commented Apr 23, 2024

@morimoto-cybozu
I will talk about these RPs in tommrrow morining meeting.

@takara9 takara9 requested review from umezawatakeshi and removed request for morimoto-cybozu April 24, 2024 01:08
umezawatakeshi
umezawatakeshi requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@umezawatakeshi umezawatakeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR title (and commit message) does not describe its content.

It should be "add MySQL 8.0.36 container image", for example.

@takara9 takara9 changed the title Update mysql 8.0.36 Add MySQL 8.0.36 container image Apr 24, 2024
umezawatakeshi
umezawatakeshi requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@umezawatakeshi umezawatakeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit message still not changed.

@takara9
Copy link
Contributor Author

takara9 commented Apr 25, 2024

@umezawatakeshi
Sorry, I updated the commit message.

@takara9 takara9 merged commit 63c8e96 into main Apr 26, 2024
18 checks passed
@takara9 takara9 deleted the update-for-k8s-1.28-No4 branch April 26, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umezawatakeshi umezawatakeshi umezawatakeshi approved these changes

Assignees

@takara9 takara9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takara9 @morimoto-cybozu @umezawatakeshi