Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent commands which take Tasks IDs taking Job IDs. #6130

Merged
merged 9 commits into from
Jun 24, 2024

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jun 10, 2024

Doing so can cause the scheduler to crash.

Branched from #6112 - drafted until that is in.
Closes #6125

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • Whilst this is technically a bug fix, I'm using a feature only available on a branch targetting master to fix it.

@wxtim wxtim marked this pull request as draft June 10, 2024 19:56
@wxtim wxtim self-assigned this Jun 10, 2024
@oliver-sanders oliver-sanders added this to the 8.3.1 milestone Jun 11, 2024
@wxtim wxtim marked this pull request as ready for review June 19, 2024 09:03
@wxtim wxtim changed the title Fix.6125 Prevent commands which take Tasks taking Jobs and crashing Jun 19, 2024
@wxtim wxtim changed the title Prevent commands which take Tasks taking Jobs and crashing Prevent commands which take Tasks IDs taking Jobs and crashing Jun 19, 2024
@wxtim wxtim changed the title Prevent commands which take Tasks IDs taking Jobs and crashing Prevent commands which take Tasks IDs taking Job IDs. Jun 19, 2024
@wxtim wxtim added the small label Jun 19, 2024
@MetRonnie MetRonnie changed the base branch from master to 8.3.x June 19, 2024 12:33
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small stuff:

cylc/flow/command_validation.py Outdated Show resolved Hide resolved
cylc/flow/command_validation.py Show resolved Hide resolved
cylc/flow/command_validation.py Show resolved Hide resolved
cylc/flow/command_validation.py Outdated Show resolved Hide resolved
cylc/flow/command_validation.py Outdated Show resolved Hide resolved
cylc/flow/command_validation.py Outdated Show resolved Hide resolved
cylc/flow/command_validation.py Outdated Show resolved Hide resolved
cylc/flow/command_validation.py Outdated Show resolved Hide resolved
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested as working, but there are a couple more commands to extend this to:

  • set
  • stop (stop tasks)
  • hold (hold tasks)

@wxtim
Copy link
Member Author

wxtim commented Jun 21, 2024

LGTM, tested as working, but there are a couple more commands to extend this to:

* set 
* stop (stop tasks)

Added these

* hold (hold tasks)

Pretty sure this was already added.

changes.d/6130.fix.md Outdated Show resolved Hide resolved
Co-authored-by: Ronnie Dutta <[email protected]>
@wxtim wxtim requested a review from MetRonnie June 24, 2024 11:57
@MetRonnie MetRonnie merged commit d715aff into cylc:8.3.x Jun 24, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

commands: traceback when specifying jobs
3 participants