Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8-bugbear: opt-in to a couple of opinionated warnings #6312

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Aug 20, 2024

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes, docs, tests, changelog needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the 8.4.0 milestone Aug 20, 2024
@MetRonnie MetRonnie self-assigned this Aug 20, 2024
raise CylcError(
'%s: contact file corrupted/modified and may be left'
% workflow_files.get_contact_file_path(scheduler.workflow)
) from None
) from exc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, the context may be useful here.

@MetRonnie MetRonnie requested a review from wxtim August 21, 2024 10:18
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit

@wxtim wxtim merged commit 3bba384 into cylc:master Aug 22, 2024
26 of 27 checks passed
@MetRonnie MetRonnie deleted the flake8-plus branch August 22, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants