Improve server-client communication error handling #6578
+378
−165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6499 we added a new field to the
trigger
GraphQL mutation, and this unfortunately broke the ability forcylc trigger
at 8.4 to work on workflows running in 8.3 (I shall term this "inter-version server-client comms").This PR does not fix that (we don't think a fix is feasible at this stage).
An additional problem is that the error handling for server-client comms is broken - that is what this PR fixes. And it attempts to ensure we have defined format for server-client comms which should reduce the chance of breaking inter-version server-client comms in future.
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.?.?.x
branch.