Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix.no validation of outputs from graph singletons #6583

Draft
wants to merge 4 commits into
base: 8.4.x
Choose a base branch
from
Draft

Fix.no validation of outputs from graph singletons #6583

wants to merge 4 commits into from

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jan 30, 2025 •
edited
Loading

Closes #6508

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim marked this pull request as draft January 30, 2025 09:38
@wxtim wxtim self-assigned this Jan 30, 2025
@wxtim wxtim added the bug Something is wrong :( label Jan 30, 2025
@wxtim wxtim added this to the 8.4.1 milestone Jan 30, 2025
@wxtim wxtim linked an issue Jan 30, 2025 that may be closed by this pull request
lone custom outputs ignored #6508
Open
@wxtim wxtim force-pushed the fix.no_validation_of_outputs_from_graph_singletons branch 5 times, most recently from 9ab665a to e9b7e6e Compare February 3, 2025 11:30
@wxtim wxtim marked this pull request as ready for review February 3, 2025 12:38
@hjoliver
Copy link
Member

hjoliver commented Feb 3, 2025

(See new comment on the issue #6508 (comment) )

hjoliver
hjoliver requested changes Feb 3, 2025
View reviewed changes
changes.d/6583.fix.md Outdated Show resolved Hide resolved
cylc/flow/config.py Outdated Show resolved Hide resolved
cylc/flow/config.py Outdated Show resolved Hide resolved
cylc/flow/config.py Outdated Show resolved Hide resolved
@wxtim wxtim requested a review from hjoliver February 5, 2025 13:11
wxtim added 2 commits February 5, 2025 15:40
@wxtim
Ensure that undefined optional outputs raise an error everywhere in g…
5cbd399 
…raph.
@wxtim
Response to reviews
bdadd4b 
Update changes.d/6583.fix.md

Co-authored-by: Hilary James Oliver <[email protected]>

Update cylc/flow/config.py

Co-authored-by: Hilary James Oliver <[email protected]>

respond to Hilary's review: Don't check all outputs only terminals.

use regexs to sort out issues with qualifiers, suicide triggers &c

mypy
@wxtim wxtim force-pushed the fix.no_validation_of_outputs_from_graph_singletons branch from 793bb30 to bdadd4b Compare February 5, 2025 15:41
@wxtim wxtim marked this pull request as draft February 6, 2025 10:05
@wxtim wxtim force-pushed the fix.no_validation_of_outputs_from_graph_singletons branch from ad1fb9f to c162aaf Compare February 6, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders Awaiting requested review from oliver-sanders

@hjoliver hjoliver Awaiting requested review from hjoliver

Requested changes must be addressed to merge this pull request.

Assignees

@wxtim wxtim

Labels
bug Something is wrong :(
Projects
None yet
Milestone
8.4.1
Development

Successfully merging this pull request may close these issues.

lone custom outputs ignored
2 participants
@wxtim @hjoliver