Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toolbar toggle button color not changing #1502

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Fix toolbar toggle button color not changing #1502

merged 2 commits into from
Oct 5, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Oct 3, 2023 •
edited
Loading

Partial revert of 74670c0

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed

@MetRonnie MetRonnie added the small label Oct 3, 2023
@MetRonnie MetRonnie added this to the 2.2.0 milestone Oct 3, 2023
@MetRonnie MetRonnie self-assigned this Oct 3, 2023
@MetRonnie MetRonnie added the bug Something isn't working label Oct 3, 2023
oliver-sanders
oliver-sanders approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These things need to remain reactive then?

@MetRonnie
Copy link
Member Author

I haven't reasoned why but yes it seems so

@oliver-sanders
Copy link
Member

Taking a peek, I expect it's the value fields which makes sense.

@oliver-sanders oliver-sanders merged commit ca52b8f into cylc:master Oct 5, 2023
@MetRonnie MetRonnie deleted the toggle-button branch October 5, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
bug Something isn't working small
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MetRonnie @oliver-sanders