Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up event listener; fix warning in test #1819

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Clean up event listener; fix warning in test #1819

merged 2 commits into from
Jun 18, 2024

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Jun 7, 2024 •
edited
Loading

Missed this out in #1802

Plus fix warning in test missed in #1794

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).

@MetRonnie MetRonnie added the small label Jun 7, 2024
@MetRonnie MetRonnie added this to the 2.5.0 milestone Jun 7, 2024
@MetRonnie MetRonnie self-assigned this Jun 7, 2024
@MetRonnie MetRonnie changed the title Clean up event listener Clean up event listener; fix warning in test Jun 11, 2024
@oliver-sanders oliver-sanders modified the milestones: 2.5.0, 2.6.0 Jun 12, 2024
@MetRonnie
Copy link
Member Author

IMO we should get this in for 2.5.0

@MetRonnie MetRonnie modified the milestones: 2.6.0, 2.5.0 Jun 18, 2024
@MetRonnie MetRonnie requested a review from wxtim June 18, 2024 09:16
wxtim
wxtim approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Have had a quick play with the GUI on this branch.

oliver-sanders
oliver-sanders approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested animation restoration still works

@oliver-sanders oliver-sanders merged commit edd69f8 into cylc:master Jun 18, 2024
8 checks passed
@MetRonnie MetRonnie deleted the event-bus branch June 18, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
small
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @oliver-sanders @wxtim