Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated asyncio loop arg #390

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Oct 4, 2022

These changes partially address:

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes applied to setup.cfg.
  • Does not need tests
  • No change log entry required (invisible to users).
  • No documentation update required.

@MetRonnie MetRonnie added the small label Oct 4, 2022
@MetRonnie MetRonnie added this to the 1.2.0 milestone Oct 4, 2022
@MetRonnie MetRonnie self-assigned this Oct 4, 2022
@MetRonnie
Copy link
Member Author

MetRonnie commented Oct 4, 2022

Style test failing, needs:

@MetRonnie
Copy link
Member Author

Kicking tests

@MetRonnie MetRonnie closed this Oct 6, 2022
@MetRonnie MetRonnie reopened this Oct 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 79.89% // Head: 79.89% // No change to project coverage 👍

Coverage data is based on head (a23f453) compared to base (549afbd).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files          12       12           
  Lines        1159     1159           
  Branches      219      196   -23     
=======================================
  Hits          926      926           
  Misses        196      196           
  Partials       37       37           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hjoliver hjoliver merged commit da038f0 into cylc:master Oct 11, 2022
@MetRonnie MetRonnie deleted the asyncio branch October 11, 2022 11:10
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me! .. err too late

@MetRonnie MetRonnie mentioned this pull request Oct 11, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants