-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypht: Improve interface so user is warned about the need for App Password for Gmail-IMAP #538
Cypht: Improve interface so user is warned about the need for App Password for Gmail-IMAP #538
Conversation
@jeanpaulHamuli Some have a Google-powered email that is not @gmail.com, so can you find a way to cover this use case? |
Yes, I'm looking for other possible forms of Gmail address, then implementing a general solution. |
When users are adding an email via https://github.com/jasonmunro/cypht/tree/master/modules/nux we know which provider it is. And if the email is set up manually, we can compare IMAP/SMTP settings: https://github.com/jasonmunro/cypht/blob/master/modules/nux/services.php |
Okay, I'm working on it @marclaporte |
d5dc003
to
04a0026
Compare
4ee7cb9
to
c68e949
Compare
Appreciate the work on this, couple things:
Happy to add more details if you need guidance. Thanks again! |
f5ef302
to
7055acb
Compare
Thank you for your comment @jasonmunro, |
sorry should have said "no longer HTML". The trans() call also applies htmlsafe, so any embeded html will end being rendered as text. I see you made multiple trans() calls as a way to work around that but the problem there is that is not easy to translate as it is bits of text that may not line up in other languages. The correct way to do this is to use %s placeholders and sprintf():
|
Ok, I understand the idea, but the implementation is not too clear to me. |
Almost, I would go with this:
|
b096c8f
to
439e2e9
Compare
It's done. |
…sword for Gmail-IMAP
8c97fd4
to
7f273d5
Compare
Is there anything else or a fix we need to add to this PR to make it more perfect to be merged? |
@jeanpaulHamuli GitHub says: "This branch cannot be rebased due to conflicts" |
I don't understand why they say that, there is no conflict in this branch @marclaporte |
@jeanpaulHamuli ok, we'll see what @jasonmunro says |
Big picture about "On May 30, 2022, you may lose access to apps that are using less secure sign-in technology" |
The removing of the less secure app access feature puts this PR at a serious disadvantage |
Disadvantage? You mean this PR becomes kind of void as the less secure access does not work any more, right? |
Yes, but since we still have Gmail in the app, we can improve and warn the user that they cannot use gmail account in less secure app |
Oh yeah, that is true. But I do not see any disadvantage there - it is as it is (because Google mandates how things will be). |
I have a Google for domains account, and it still works. But one of my Gmail accounts stopped working and I discovered this issue: #573 |
@adrienmaloba Please revisit this, evaluate and make a recommendation. |
We are going to put this (and all Cypht-Gmail related work) on hold for a few months, as we focus on the release of Cypht 1.4 and improving Cypht for standard IMAP and SMTP. This being said, I welcome anyone in the community to contribute code, bug reports or documentation with respect to Gmail and Cypht. There are a lot of Gmail accounts out there. I use Cypht for a Gmail account (via IMAP) and it works fine. The only issue is that I need to sort by "Arrival Date" instead of "Sent Date". |
Indeed. Closing this. Let's focus on "Review the whole process/code/documentation for Cypht to work for Google and Microsoft's email offerings" here: #776 |
Improve interface so the user is warned about the need for App Password for Gmail-IMAP
Pullrequest
Issues
Checklist
How2Test
Todo