-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CYCLOUD-1740 multi repo best practices #5562
Conversation
✅ Deploy Preview for benevolent-cat-040f48 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
### Multi-repo Implementation | ||
|
||
There is a sceario where you may have Cypress tests in a repo separate from the application code itself. This creates a sub-optimal [Branch Review](guides/cloud/branch-review) experience considering the commit and branch interpretation of each git directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a sceario where you may have Cypress tests in a repo separate from the application code itself. This creates a sub-optimal [Branch Review](guides/cloud/branch-review) experience considering the commit and branch interpretation of each git directory. | |
There is a scenario where you may have Cypress tests in a repo separate from the application code itself. This creates a sub-optimal [Branch Review](guides/cloud/branch-review) experience considering the commit and branch interpretation of each git directory. |
...though I wonder if we need to explicitly call out branch review here; it'd be problematic for really any sort of VCS integration we have, including statuses/PR comments, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. I figured it may be useful to callout a practical area in the product this would impact but we can make it more general to VC.
@pstakoun any other thoughts so I can batch changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with making it more general and also mention Branch Review as an example of a feature that is impacted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pstakoun I took out the direct mention of branch review in the last commit. Are you saying we should still leverage it in some way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nah this is fine. I'd just maybe link to this section from within the branch review docs
|
||
- Link the GitHub integration to the Cypress config/tests repo | ||
- Ensure any runs recorded to **Test Project** are related to test code changes in the Cypress config/tests repo | ||
- the application code repo state that the tests are executed against here could likewise be captured as tags here, if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the application code repo state that the tests are executed against here could likewise be captured as tags here, if necessary. | |
- The application code repo state that the tests are executed against here could likewise be captured as tags here, if necessary. |
|
||
### Multi-repo Implementation | ||
|
||
There is a sceario where you may have Cypress tests in a repo separate from the application code itself. This creates a sub-optimal [Branch Review](guides/cloud/branch-review) experience considering the commit and branch interpretation of each git directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with making it more general and also mention Branch Review as an example of a feature that is impacted.
8868f42
to
9a2ccc9
Compare
98f467c
to
1c498af
Compare
Add Cloud project best practices around having tests in a different repo than the source code.