Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve accessibility for Docs #6068

Merged
merged 12 commits into from
Jan 7, 2025
Merged

fix: Improve accessibility for Docs #6068

merged 12 commits into from
Jan 7, 2025

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jan 6, 2025

This PR contains fixes for the majority of Accessibility violations that are within our direct control. The remaining violations are mostly involving external libraries (cookie consent popup, search popup, docusaurus defaults). So the fixes for those will be more involved.

Before

Rule Violations

Screenshot 2025-01-07 at 11 21 56 AM

After

Rule Violations

Screenshot 2025-01-07 at 11 22 18 AM

Copy link

cypress bot commented Jan 6, 2025

cypress-documentation    Run #243

Run Properties:  status check passed Passed #243  •  git commit dc1e69d6c6: Fix broken link
Project cypress-documentation
Branch Review a11y-fixes-1
Run status status check passed Passed #243
Run duration 08m 44s
Commit git commit dc1e69d6c6: Fix broken link
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 290
View all changes introduced in this branch ↗︎
UI Coverage  11%
  Untested elements 2292  
  Tested elements 3  
Accessibility  96.89%
  Failed rules  1 critical   4 serious   4 moderate   0 minor
  Failed elements 441  

@jennifer-shehane jennifer-shehane self-assigned this Jan 7, 2025
@jennifer-shehane jennifer-shehane merged commit ca75c90 into main Jan 7, 2025
10 checks passed
@jennifer-shehane jennifer-shehane deleted the a11y-fixes-1 branch January 7, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant