refactor: use an xml parser for less brittle mocha result verification #30865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
cacie/refactor/test-result-verification
|
| Run status |
|
| Run duration | 16m 49s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
73
|
Skipped
|
0
|
Passing
|
5621
|
| View all changes introduced in this branch ↗︎ | |
Warning
No Report: Something went wrong and we could not generate a report for the Application Quality products.
AtofStryker
approved these changes
Jan 13, 2025
|
@cacieprins Could you resolve the conflicts here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
After running unit tests in CI, the
verify-mocha-resultsscript is executed. This script ensures that:/tmp/cypress/junitCurrently, a regex is used to extract attributes from the xml regarding the success or failure of tests for a given report. Unfortunately, mocha's junit reporter writes attributes in a different order than vitest's junit reporter. Using an xml parser allows the verification step to be more flexible about the order of attributes in the junit reports it parses.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?