fix: Error codeframes in retry failures display the code that produced the error #30962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
cacie/30927/retry-error-codeframe
|
| Run status |
|
| Run duration | 17m 53s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
7
|
Pending
|
1099
|
Skipped
|
0
|
Passing
|
26522
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.68%
|
|
|---|---|
|
Untested elements
|
190
|
|
Tested elements
|
164
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
891
|
AtofStryker
approved these changes
Jan 28, 2025
| @@ -10,6 +10,7 @@ _Released 1/28/2025_ | |||
| - Fixed a regression introduced in [`14.0.0`](https://docs.cypress.io/guides/references/changelog#14-0-0) where the incorrect visiblity would be returned when either `overflow-x` or `overflow-y` was visible but the other one was clipping. Fixed in [#30934](https://github.com/cypress-io/cypress/pull/30934). | |||
| - Fixed an issue where an `option` element would not return the correct visibility if its parent element has a clipping overflow. Fixed in [#30934](https://github.com/cypress-io/cypress/pull/30934). | |||
| - Fixed an issue where non-HTMLElement(s) may fail during assertions. Fixes [#30944](https://github.com/cypress-io/cypress/issues/30944) | |||
| - Fixed a regression introduced in [`14.0.0`](https://docs.cypress.io/guides/references/changelog#14-0-0) where error codeframes in the runner UI were not populated with the correct data in failed retry attempts. Fixes [#30927](https://github.com/cypress-io/cypress/issues/30927). | |||
There was a problem hiding this comment.
we need to move this to 14.0.2
|
|
||
| const invocationFrame = second ?? first | ||
|
|
||
| //console.log(invocationFrame) |
There was a problem hiding this comment.
Suggested change
| //console.log(invocationFrame) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
With Cypress 14.0.0, the raw user invocation stacks can include codepoints that are internal to Cypress. The patterns we were searching during 14.0.0 were not robust enough.
Depending on several factors, the path to the first userland codepoint had many potential patterns. Trying to include them all one by one proved troublesome. Instead, now, we identify which style of paths the internal codepoints use and strip them out - there are fewer potential options here.
Steps to test
Write an E2E test that fails a determinate number of times before passing, and configure it to retry until it passes. With the binary, run the test and expand one of the failed test attempts. The codeframe should point to the assertion failure in the test.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?