dependency: bump mime dependency to 3.0 #30966
Merged
+76
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
mime-dep-update
|
| Run status |
|
| Run duration | 17m 46s |
| Commit |
|
| Committer | cypress-bot[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
5
|
Pending
|
1099
|
Skipped
|
0
|
Passing
|
26522
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
45.43%
|
|
|---|---|
|
Untested elements
|
192
|
|
Tested elements
|
164
|
Accessibility
92.54%
|
|
|---|---|
|
Failed rules
|
3 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
888
|
… into mime-dep-update
jennifer-shehane
changed the title
added 8 commits
January 29, 2025 17:58
mschile
approved these changes
Jan 29, 2025
jennifer-shehane
requested review from
ryanthemanuel
and removed request for
AtofStryker
ryanthemanuel
approved these changes
Jan 30, 2025
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mimecurrent version 4.x #30144Additional details
This updates
mimeto 3.0. I attempted to update to 4.x and remove thetypessince they are included inmimenow, but we needservicesto be an esm package completely to do that. See thread.mimeversion 2 was working becausemimenotes that renaming oflookuptogetTypewas a breaking change from v1 to v2. https://github.com/broofa/mime/tree/v2.6.0?tab=readme-ov-file#version-2-notestext/javascriptinstead ofapplication/javascriptfor JS files.application/javascriptis obsolete according to https://www.iana.org/assignments/media-types/media-types.xhtml. But since we're staying on 3.0 - this is no longer relevant. I did however update some tests that were definingapplication/javascripttotext/javascript- this is NOT related to the mime update at all, just figured I'd update it while I'm here, but I can pull out if needed.mimeandmime-db, but I didn't investigate these differences at this time.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?