refactor: begin to use axios for cloud api requests #31041
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
As a first step in removing @cypress/request, this shifts the API call to create an instance to Axios.
api/index.ts
fileasyncRetry
util.axios-retry
was considered, but the additional package size and complications regarding overriding behavior for POSTs made it untimely.@packages/server
, but should be considered a TODO if we migrate to vitest.Note: while this request is a POST, and POSTs are not typically retry-able, this endpoint is now idempotent. Retries are enabled in order to improve resiliency to network splits, etc.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?