Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency tough-cookie to v4 [security] #31042

Closed
wants to merge 3 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 6, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tough-cookie 2.5.0 -> 4.1.3 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2023-26136

Versions of the package tough-cookie before 4.1.3 are vulnerable to Prototype Pollution due to improper handling of Cookies when using CookieJar in rejectPublicSuffixes=false mode. This issue arises from the manner in which the objects are initialized.


Release Notes

salesforce/tough-cookie (tough-cookie)

v4.1.3: 4.1.3

Compare Source

Security fix for Prototype Pollution discovery in #​282. This is a minor release, although output from the inspect utility is affected by this change, we felt this change was important enough to be pushed into the next patch.

v4.1.2: 4.1.2 -- Patch and Bugfix Release

Compare Source

What's Changed

Full Changelog: salesforce/tough-cookie@v4.1.1...v4.1.2

v4.1.1: 4.1.1

Compare Source

Patch Release

What's Changed

Full Changelog: salesforce/tough-cookie@v4.1.0...v4.1.1

v4.1.0: 4.1.0

Compare Source

v4.1.0

Minor release, focused mainly on resolving reported issues and some minor feature work.

What's Changed

New Contributors

Full Changelog: salesforce/tough-cookie@v4.0.0...v4.1.0

v4.0.0: Version 4.0.0

Compare Source

Breaking Changes (Major Version)
  • Modernized JS Syntax
    • Use ESLint and Prettier to apply consistent, modern formatting (add dependency on universalify, eslint and prettier)
  • Upgraded version dependencies for psl and async
  • Re-order parameters for findCookies() - callback fn has to be last in order to comply with universalify
  • Use Classes instead of function prototypes to define classes
    • Might break people using .call() to do inheritance using function prototypes
Minor Changes
  • SameSite cookie support
  • Cookie prefix support
  • Support for promises
  • '.local' support
  • Numerous bug fixes!

v3.0.1

Compare Source

v3.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@cypress-app-bot
Copy link
Collaborator

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@jennifer-shehane jennifer-shehane self-requested a review February 7, 2025 18:49
@jennifer-shehane
Copy link
Member

This seems to be out of date...

Copy link
Contributor Author

renovate bot commented Feb 7, 2025

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 4.x releases. But if you manually upgrade to 4.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate renovate bot deleted the renovate/npm-tough-cookie-vulnerability branch February 7, 2025 19:01
Copy link

cypress bot commented Feb 7, 2025

cypress    Run #60293

Run Properties:  status check passed Passed #60293  •  git commit 2b91aa657e: Merge branch 'develop' into renovate/npm-tough-cookie-vulnerability
Project cypress
Branch Review renovate/npm-tough-cookie-vulnerability
Run status status check passed Passed #60293
Run duration 17m 27s
Commit git commit 2b91aa657e: Merge branch 'develop' into renovate/npm-tough-cookie-vulnerability
Committer Jennifer Shehane
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 7
Tests that did not run due to a developer annotating a test with .skip  Pending 1099
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26542
View all changes introduced in this branch ↗︎
UI Coverage  45.56%
  Untested elements 191  
  Tested elements 164  
Accessibility  92.54%
  Failed rules  3 critical   8 serious   2 moderate   2 minor
  Failed elements 890  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants