Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add git information docs reference and example #1091

Merged
merged 7 commits into from
Dec 8, 2023
Merged

docs: add git information docs reference and example #1091

merged 7 commits into from
Dec 8, 2023

Conversation

conversayShawn
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conversayShawn conversayShawn self-assigned this Dec 6, 2023
MikeMcC399

This comment was marked as resolved.

Sign in to view

@MikeMcC399

This comment was marked as resolved.

Sign in to view
@conversayShawn
Copy link
Contributor Author

@MikeMcC399

If "Cloud" means "Cypress Cloud" then please change the terms to say "Cypress Cloud" explicitly.
Good call.

Does it relate to https://github.com/cypress-io/github-action#automatic-pr-number--url-detection and should it be placed adjacent to this section?
It appears some of the info might be more readable with different structuring. Let me know if this grouping is a viable option.

It seems that this PR is related to a Discord post https://discord.com/channels/755913899261296641/1181347411940102294 about merge queues.
Correct. The main goal here is to make it as simple as possible for users to find their answers in the documentation.

Does .github/workflows/example-recording.yml need to be updated?
Possibly, but it's not a necessity.

@MikeMcC399 MikeMcC399 added the documentation Improvements or additions to documentation label Dec 7, 2023
MikeMcC399
MikeMcC399 reviewed Dec 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
MikeMcC399

This comment was marked as resolved.

Sign in to view

MikeMcC399

This comment was marked as resolved.

Sign in to view

MikeMcC399
MikeMcC399 reviewed Dec 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
MikeMcC399
MikeMcC399 reviewed Dec 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
MikeMcC399
MikeMcC399 reviewed Dec 7, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@conversayShawn conversayShawn changed the title add git information docs reference and example docs: add git information docs reference and example Dec 7, 2023
conversayShawn and others added 4 commits December 7, 2023 07:30
@conversayShawn @MikeMcC399
Update README.md
02a3c8f 
Fix capitalization and expand abbreviations

Co-authored-by: Mike McCready <[email protected]>
@conversayShawn @MikeMcC399
Update README.md
48df368 
Fix capitalization and add commit-info link

Co-authored-by: Mike McCready <[email protected]>
@conversayShawn @MikeMcC399
Update README.md
d4e358b 
Fix capitalization

Co-authored-by: Mike McCready <[email protected]>
@conversayShawn
Update README.md
b4f8114 
Clarify projectID and recordKey instructions
MikeMcC399
MikeMcC399 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennifer-shehane jennifer-shehane merged commit 90baf43 into master Dec 8, 2023
71 checks passed
@jennifer-shehane jennifer-shehane deleted the gitEnvVars branch December 8, 2023 23:33
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcC399 MikeMcC399 MikeMcC399 approved these changes

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees

@conversayShawn conversayShawn

Labels
documentation Improvements or additions to documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conversayShawn @CLAassistant @MikeMcC399 @jennifer-shehane