Skip to content
This repository has been archived by the owner on Dec 10, 2024. It is now read-only.

Config: add understanding of imapd.conf BITFIELDs #153

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

elliefm
Copy link
Contributor

@elliefm elliefm commented Aug 30, 2021

This will let us treat 'httpmodules' et al as the set of flags it is, rather than an opaque string.

Need this for some refactoring I have planned for #151, but splitting it out so it can be reviewed separately

@elliefm elliefm marked this pull request as draft August 30, 2021 02:14
@elliefm
Copy link
Contributor Author

elliefm commented Aug 30, 2021

Wanted to make sure this works okay with older Cyrus releases... but it turns out the new Instance sanity checks in #146 can cause non-clean shutdown and cascading errors, and the sanity checks find problems on older Cyrus releases, so the tests all blow up dramatically.

So off down another rabbit hole I go...

@elliefm
Copy link
Contributor Author

elliefm commented Aug 30, 2021

Seems like this'll be okay once #154 is merged, so waiting for that.

This will let us treat 'httpmodules' et al as the set of flags it is,
rather than an opaque string
@elliefm elliefm force-pushed the config-bitfields-support branch from ccfa48e to 1400b1b Compare September 1, 2021 05:52
@elliefm elliefm marked this pull request as ready for review September 1, 2021 06:00
@elliefm elliefm merged commit d1cd355 into cyrusimap:master Sep 1, 2021
@elliefm elliefm deleted the config-bitfields-support branch September 1, 2021 06:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants