rework to be built on top of standard cyrus-docker image #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we can rebuild nightly (or whenever) very quickly, minimal duplication of work.
rjbs
force-pushed
the
build-on-cyrus-docker
branch
from
b3238e7 to
4bef4db
Compare
|
@brong I think this should have no effect on the behavior of the test service, but it should be a bit faster to build one, built on top of the nightly Cyrus image, or (with a small tweak) any other Docker image we want to build. The idea here is: make it easy to make our general-purpose starting images, then this is one kind of layer we put on top of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can rebuild nightly (or whenever) very quickly, minimal duplication of work.