Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version metadata to CytoTable Parquet output #134

Merged
merged 25 commits into from
Dec 20, 2023

Conversation

d33bs
Copy link
Member

@d33bs d33bs commented Dec 19, 2023

Description

This PR continues forward from work found within #132 . It adds version metadata to all Parquet output from CytoTable to address #19 . For review of this material I recommend focusing on changes under the /cytotable/ and /tests/ dirs (other changes are part of #132).

Closes #19

What is the nature of your change?

  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist

Please ensure that all boxes are checked before indicating that a pull request is ready for review.

  • I have read the CONTRIBUTING.md guidelines.
  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • New and existing unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have deleted all non-relevant text in this pull request template.

cytotable/__init__.py Outdated Show resolved Hide resolved
cytotable/utils.py Outdated Show resolved Hide resolved
cytotable/utils.py Show resolved Hide resolved
docs/source/contributing.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@d33bs
Copy link
Member Author

d33bs commented Dec 20, 2023

Thank you @gwaybio ! I've addressed your comments and will merge this in now.

@d33bs d33bs merged commit 9781519 into cytomining:main Dec 20, 2023
7 checks passed
@d33bs d33bs deleted the data-versioned-output branch December 20, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include versioning metadata within output files
2 participants