Fix video preview creating cache files that are not being deleted if the app is killed #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n creating video previews When SD Maid generates thumbnails for large videos via coil, then large `.tmp` files can be created. If SD Maid is killed before thumbnail generation has finished, then these `.tmp` can stay around until manually deleted. This PR changes the path where these files are stored, and deleted any orphaned files `.tmp` files on the next app launch. Also see coil-kt/coil#2550
…reviews When SD Maid generates thumbnails for large videos via coil, then large `.tmp` files can be created. If SD Maid is killed before thumbnail generation has finished, then these `.tmp` can stay around until manually deleted. This PR changes the path where these files are stored, and deleted any orphaned files `.tmp` files on the next app launch. Also see coil-kt/coil#2550
…previews for videos could consume huge amounts of space at once
…mbnails # Conflicts: # app/src/main/java/eu/darken/sdmse/common/coil/CoilTempFiles.kt
d4rken
added
bug
d4rken
added a commit
that referenced
this pull request
Oct 17, 2024
Replace the previous sepperate read/write functions. Allows `Coil` to efficiently load video thumbnails. Improves SAF performance. See #1434 See coil-kt/coil#2550
d4rken
added a commit
that referenced
this pull request
Oct 18, 2024
Replace the previous sepperate read/write functions. Allows `Coil` to efficiently load video thumbnails. Improves SAF performance. See #1434 See coil-kt/coil#2550
d4rken
added a commit
that referenced
this pull request
Oct 18, 2024
Replace the previous sepperate read/write functions. Allows `Coil` to efficiently load video thumbnails. Improves SAF performance. See #1434 See coil-kt/coil#2550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SD Maid generates thumbnails for large videos via coil, then large
.tmpfiles can be created.If SD Maid is killed before thumbnail generation has finished, then these
.tmpcan stay around until manually deleted.This PR changes the path where these files are stored, and deletes any orphaned files
.tmpfiles on the next app launch.Also see coil-kt/coil#2550
Thanks to Martin for pointing this out 🙏